Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheets-ui): recover float-dom delete menu & focusing when zen-editor mount #3426

Merged
merged 6 commits into from
Sep 13, 2024

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Sep 13, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Sep 13, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Sep 13, 2024

Playwright test results

passed  4 passed

Details

stats  4 tests across 2 suites
duration  1 minute, 28 seconds
commit  0b7e55f
info  For more information, see full report

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 30.56%. Comparing base (e736b8a) to head (0b7e55f).
Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
...en-editor/src/controllers/zen-editor.controller.ts 0.00% 3 Missing ⚠️
...-hyper-link-ui/src/controllers/popup.controller.ts 0.00% 2 Missing ⚠️
.../src/services/zen-zone/desktop-zen-zone.service.ts 0.00% 2 Missing ⚠️
...ocs-ui/src/services/clipboard/clipboard.service.ts 0.00% 1 Missing ⚠️
...i/src/controllers/drawing-popup-menu.controller.ts 0.00% 1 Missing ⚠️
...rc/controllers/editor/editing.render-controller.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3426      +/-   ##
==========================================
- Coverage   30.56%   30.56%   -0.01%     
==========================================
  Files        2155     2155              
  Lines      112726   112728       +2     
  Branches    24712    24713       +1     
==========================================
  Hits        34458    34458              
- Misses      78268    78270       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@weird94 weird94 changed the title fix(sheets-hyper-link): zen editor popup should hide when selection change fix(sheets-hyper-link): recover float-dom delete menu & focusing when zen-editor mount Sep 13, 2024
@weird94 weird94 changed the title fix(sheets-hyper-link): recover float-dom delete menu & focusing when zen-editor mount fix(sheets-ui): recover float-dom delete menu & focusing when zen-editor mount Sep 13, 2024
@weird94 weird94 merged commit 2bf1177 into dev Sep 13, 2024
10 checks passed
@weird94 weird94 deleted the fix/zen-editor-link branch September 13, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants