-
-
Notifications
You must be signed in to change notification settings - Fork 718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: better facade comment #4402
Conversation
a566672
to
24c91b4
Compare
View Deployment
|
Playwright test resultsDetails
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #4402 +/- ##
==========================================
- Coverage 33.13% 33.07% -0.06%
==========================================
Files 2549 2550 +1
Lines 131470 131630 +160
Branches 29294 29337 +43
==========================================
- Hits 43562 43541 -21
- Misses 87908 88089 +181 ☔ View full report in Codecov by Sentry. |
24c91b4
to
4d29e5f
Compare
44d3214
to
3ddf142
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
b23b2c0
to
bc65a4f
Compare
packages/sheets-conditional-formatting/src/facade/f-worksheet.ts
Outdated
Show resolved
Hide resolved
bc65a4f
to
1d20499
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good job
4af3df6
to
735b54f
Compare
chore: better code
735b54f
to
72bf2ac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am doing this in another PR, still working in progress. |
I am doing this in another PR, still working in progress. |
close #xxx
Pull Request Checklist