Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: better facade comment #4402

Merged
merged 5 commits into from
Jan 6, 2025
Merged

fix: better facade comment #4402

merged 5 commits into from
Jan 6, 2025

Conversation

lumixraku
Copy link
Contributor

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Jan 2, 2025

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Jan 2, 2025

Playwright test results

passed  21 passed

Details

stats  21 tests across 10 suites
duration  4 minutes, 47 seconds
commit  72bf2ac
info  For more information, see full report

Copy link

codecov bot commented Jan 2, 2025

Codecov Report

Attention: Patch coverage is 0% with 52 lines in your changes missing coverage. Please review.

Project coverage is 33.07%. Comparing base (5ae246e) to head (72bf2ac).
Report is 3 commits behind head on dev.

Files with missing lines Patch % Lines
...ckages/sheets-drawing-ui/src/facade/f-worksheet.ts 0.00% 12 Missing ⚠️
packages/sheets-ui/src/facade/f-worksheet.ts 0.00% 10 Missing ⚠️
packages/sheets/src/facade/f-workbook.ts 0.00% 10 Missing ⚠️
packages/sheets-ui/src/facade/f-workbook.ts 0.00% 8 Missing ⚠️
packages/sheets/src/facade/f-worksheet.ts 0.00% 6 Missing ⚠️
packages/sheets-ui/src/facade/f-range.ts 0.00% 3 Missing ⚠️
...s-conditional-formatting/src/facade/f-worksheet.ts 0.00% 2 Missing ⚠️
...es/sheets-thread-comment/src/facade/f-worksheet.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4402      +/-   ##
==========================================
- Coverage   33.13%   33.07%   -0.06%     
==========================================
  Files        2549     2550       +1     
  Lines      131470   131630     +160     
  Branches    29294    29337      +43     
==========================================
- Hits        43562    43541      -21     
- Misses      87908    88089     +181     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lumixraku lumixraku force-pushed the fix/better-facade-comment branch from 24c91b4 to 4d29e5f Compare January 2, 2025 09:18
@lumixraku lumixraku requested a review from Dushusir January 2, 2025 09:19
@lumixraku lumixraku force-pushed the fix/better-facade-comment branch 2 times, most recently from 44d3214 to 3ddf142 Compare January 3, 2025 06:26
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/sheets-data-validation/src/facade/f-workbook.ts Outdated Show resolved Hide resolved
@lumixraku lumixraku force-pushed the fix/better-facade-comment branch 3 times, most recently from b23b2c0 to bc65a4f Compare January 4, 2025 09:23
@lumixraku lumixraku force-pushed the fix/better-facade-comment branch from bc65a4f to 1d20499 Compare January 4, 2025 09:41
Copy link
Contributor

@VicKun4937 VicKun4937 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job

packages/sheets-drawing-ui/src/facade/f-worksheet.ts Outdated Show resolved Hide resolved
packages/sheets-drawing-ui/src/facade/f-worksheet.ts Outdated Show resolved Hide resolved
packages/sheets-hyper-link/src/facade/f-workbook.ts Outdated Show resolved Hide resolved
packages/sheets-hyper-link/src/facade/f-workbook.ts Outdated Show resolved Hide resolved
packages/sheets-ui/src/facade/f-worksheet.ts Outdated Show resolved Hide resolved
@lumixraku lumixraku force-pushed the fix/better-facade-comment branch 3 times, most recently from 4af3df6 to 735b54f Compare January 4, 2025 12:03
@lumixraku lumixraku force-pushed the fix/better-facade-comment branch from 735b54f to 72bf2ac Compare January 4, 2025 12:39
Copy link
Contributor

@weird94 weird94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@weird94 weird94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@univer-bot
Copy link

univer-bot bot commented Jan 6, 2025

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

https://doc.weixin.qq.com/sheet/e3_AawAUwY_AEcVFliUZAqQ3W4x1YbLT?scode=ANUAgwcMAD4KMqukwKAawAUwY_AEc&is_external=0&commentVersion=1735 994649000&doc_title=Univer+Sheet+FacadeAPI&wxworkQt=1&qt_source=Conv&qt_report_identifier=1736006055105&open_source=timeline&tab=ndjw35 Need to implement sheet-related events

I am doing this in another PR, still working in progress.

@lumixraku lumixraku merged commit 59a1774 into dev Jan 6, 2025
9 checks passed
@lumixraku lumixraku deleted the fix/better-facade-comment branch January 6, 2025 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants