Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheet): insert row/col undo bug #1350

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Conversation

Gggpound
Copy link
Contributor

@Gggpound Gggpound commented Feb 7, 2024

  • I am sure that the code is update-to-date with the dev branch.

close #

Copy link

github-actions bot commented Feb 7, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.72%. Comparing base (bd57a84) to head (e9497ed).
Report is 89 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1350      +/-   ##
==========================================
- Coverage   29.72%   29.72%   -0.01%     
==========================================
  Files         844      844              
  Lines       47874    47874              
  Branches     9813     9813              
==========================================
- Hits        14231    14230       -1     
- Misses      33643    33644       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wzhudev wzhudev added the pr:need auto tests This PR needs automatic tests. label Feb 7, 2024
@wzhudev
Copy link
Member

wzhudev commented Feb 7, 2024

There should be an automated test to cover this case.

@wzhudev wzhudev added the qa:untested This PR is ready to be tested label Feb 7, 2024
Copy link
Contributor

@yuhongz yuhongz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhaolixin7 zhaolixin7 added qa:verified This PR has already by verified by a QA and is considered good enough to be merge and removed qa:untested This PR is ready to be tested labels Mar 5, 2024
@Gggpound Gggpound merged commit 5781a63 into dev Mar 5, 2024
7 checks passed
@Gggpound Gggpound deleted the fix-insert-row-undo-error-0207 branch March 5, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:need auto tests This PR needs automatic tests. qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants