Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(formula): check syntax #1543

Merged
merged 1 commit into from
Mar 14, 2024
Merged

fix(formula): check syntax #1543

merged 1 commit into from
Mar 14, 2024

Conversation

DR-Univer
Copy link
Collaborator

@DR-Univer DR-Univer commented Mar 11, 2024

  • I am sure that the code is update-to-date with the dev branch.

close #

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Mar 11, 2024
Copy link

github-actions bot commented Mar 11, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 32.94%. Comparing base (ef48825) to head (af9496d).

Files Patch % Lines
...-formula/src/engine/analysis/lexer-tree-builder.ts 88.46% 3 Missing ⚠️
...ngine-formula/src/engine/ast-node/function-node.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1543      +/-   ##
==========================================
+ Coverage   32.91%   32.94%   +0.02%     
==========================================
  Files         919      919              
  Lines       51126    51150      +24     
  Branches    10644    10652       +8     
==========================================
+ Hits        16829    16850      +21     
- Misses      34297    34300       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DR-Univer DR-Univer merged commit 15a04ed into dev Mar 14, 2024
8 checks passed
@DR-Univer DR-Univer deleted the fix-formula-check-syntax branch March 14, 2024 03:34
ybzky pushed a commit that referenced this pull request Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:untested This PR is ready to be tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants