Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): optimize editor focus #1616

Merged
merged 4 commits into from
Mar 16, 2024
Merged

fix(editor): optimize editor focus #1616

merged 4 commits into from
Mar 16, 2024

Conversation

DR-Univer
Copy link
Collaborator

@DR-Univer DR-Univer commented Mar 16, 2024

close #wolf man mac

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Mar 16, 2024
Copy link

github-actions bot commented Mar 16, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Mar 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 32.47%. Comparing base (dcb3e93) to head (9269bed).
Report is 4 commits behind head on dev.

Files Patch % Lines
...cs/text-selection/text-selection-render-manager.ts 0.00% 10 Missing ⚠️
packages/core/src/shared/common.ts 0.00% 3 Missing ⚠️
...cs-ui/src/controllers/text-selection.controller.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1616      +/-   ##
==========================================
+ Coverage   32.45%   32.47%   +0.01%     
==========================================
  Files         924      926       +2     
  Lines       52195    52233      +38     
  Branches    10899    10901       +2     
==========================================
+ Hits        16942    16964      +22     
- Misses      35253    35269      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DR-Univer DR-Univer merged commit e4231eb into dev Mar 16, 2024
7 checks passed
@DR-Univer DR-Univer deleted the fix-editor-focus-mac branch March 16, 2024 11:20
ybzky pushed a commit that referenced this pull request Mar 19, 2024
* fix(editor): optimize editor focus

* fix(editor): firefox and regex

* fix(sheet): old version safari

* fix: regexp

---------

Co-authored-by: jocs <ransixi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:untested This PR is ready to be tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants