Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(render): punctuation adjustment in the middle of line #1686

Merged
merged 5 commits into from
Mar 29, 2024

Conversation

Jocs
Copy link
Contributor

@Jocs Jocs commented Mar 25, 2024

Fixed an issue where Compression of punctuation marks did not work in lines with both ends aligned

close #xxx, #yyy, #zzzz

Copy link

github-actions bot commented Mar 25, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@Jocs Jocs marked this pull request as ready for review March 25, 2024 08:05
@Jocs Jocs requested review from DR-Univer and wzhudev as code owners March 25, 2024 08:05
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Mar 25, 2024
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 31.62%. Comparing base (50edd34) to head (bb41ac4).

Files Patch % Lines
...nts/docs/layout/block/paragraph/line-adjustment.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1686      +/-   ##
==========================================
- Coverage   31.62%   31.62%   -0.01%     
==========================================
  Files        1039     1039              
  Lines       57725    57720       -5     
  Branches    12120    12120              
==========================================
- Hits        18258    18256       -2     
+ Misses      39467    39464       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jikkai jikkai changed the title fix: punctuation adjustment in the middle of line fix(render): punctuation adjustment in the middle of line Mar 28, 2024
@Jocs Jocs removed the qa:untested This PR is ready to be tested label Mar 28, 2024
@Jocs Jocs merged commit 2382e3b into dev Mar 29, 2024
8 checks passed
@Jocs Jocs deleted the fix/punctuation-adjustment branch March 29, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants