Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sheet): defined name #1737

Merged
merged 27 commits into from
Apr 3, 2024
Merged

feat(sheet): defined name #1737

merged 27 commits into from
Apr 3, 2024

Conversation

DR-Univer
Copy link
Collaborator

@DR-Univer DR-Univer commented Mar 29, 2024

No description provided.

@DR-Univer DR-Univer marked this pull request as draft March 29, 2024 05:07
@DR-Univer DR-Univer added the feature request New feature or request label Mar 29, 2024
@DR-Univer DR-Univer changed the title feat(sheet): defined name feat(sheet): Defined Name Mar 29, 2024
@DR-Univer DR-Univer changed the title feat(sheet): Defined Name feat(sheet): defined name Mar 29, 2024
Copy link

github-actions bot commented Mar 29, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Mar 29, 2024

Codecov Report

Attention: Patch coverage is 16.74347% with 542 lines in your changes are missing coverage. Please review.

Project coverage is 29.62%. Comparing base (8d8e615) to head (8c3b71a).
Report is 7 commits behind head on dev.

Files Patch % Lines
...ets-ui/src/views/defined-name/DefinedNameInput.tsx 0.00% 101 Missing ⚠️
...ui/src/views/defined-name/DefinedNameContainer.tsx 0.00% 88 Missing ⚠️
...ges/sheets-ui/src/controllers/scroll.controller.ts 0.00% 72 Missing ⚠️
.../sheets-ui/src/controllers/selection.controller.ts 0.00% 60 Missing ⚠️
...ts/src/controllers/defined-name-data.controller.ts 0.00% 37 Missing ⚠️
...s-ui/src/views/defined-name/DefinedNameOverlay.tsx 0.00% 26 Missing ⚠️
...gine-formula/src/services/defined-names.service.ts 50.00% 24 Missing ⚠️
...mands/operations/sidebar-defined-name.operation.ts 0.00% 19 Missing ⚠️
...ormula/src/engine/dependency/formula-dependency.ts 0.00% 16 Missing ⚠️
...ckages/engine-formula/src/engine/analysis/lexer.ts 63.88% 13 Missing ⚠️
... and 20 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1737      +/-   ##
==========================================
- Coverage   29.78%   29.62%   -0.17%     
==========================================
  Files        1143     1154      +11     
  Lines       62044    62678     +634     
  Branches    13020    13139     +119     
==========================================
+ Hits        18482    18569      +87     
- Misses      43562    44109     +547     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DR-Univer DR-Univer marked this pull request as ready for review April 1, 2024 12:48
@DR-Univer DR-Univer requested a review from Dushusir as a code owner April 1, 2024 12:48
@wzhudev wzhudev removed the feature request New feature or request label Apr 3, 2024
@DR-Univer DR-Univer merged commit cfa9375 into dev Apr 3, 2024
8 checks passed
@DR-Univer DR-Univer deleted the feat-defined-name branch April 3, 2024 12:20
@Dushusir Dushusir mentioned this pull request Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants