Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheet): data-validation delete mutation undo-redo #1781

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Apr 2, 2024

close #xxx, #yyy, #zzzz

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Apr 2, 2024
Copy link

github-actions bot commented Apr 2, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 29.78%. Comparing base (a2dd33d) to head (00a1968).

Files Patch % Lines
...dation/src/models/sheet-data-validation-manager.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1781   +/-   ##
=======================================
  Coverage   29.78%   29.78%           
=======================================
  Files        1143     1143           
  Lines       62044    62044           
  Branches    13020    13020           
=======================================
  Hits        18482    18482           
  Misses      43562    43562           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@weird94 weird94 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Apr 2, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Apr 2, 2024
@weird94
Copy link
Contributor Author

weird94 commented Apr 2, 2024

改动较小,研发自测

@univer-bot
Copy link

univer-bot bot commented Apr 2, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

Minor changes, R&D self-test

@weird94 weird94 merged commit 8d8e615 into dev Apr 2, 2024
8 checks passed
@weird94 weird94 deleted the fix/data-validation-redo-undo branch April 2, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants