Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(conditional-formatting): bugfix #1838

Merged
merged 9 commits into from
Apr 10, 2024

Conversation

Gggpound
Copy link
Contributor

@Gggpound Gggpound commented Apr 9, 2024

  1. When you hover the rule panel with the mouse, highlight the area where the rule works.
  2. Data bar supports hidden value
  3. Conditional format supports matching formula error
  4. Support for whole row and whole column selection

@Gggpound Gggpound requested a review from DR-Univer as a code owner April 9, 2024 09:10
Copy link

codecov bot commented Apr 9, 2024

Codecov Report

Attention: Patch coverage is 11.29032% with 55 lines in your changes are missing coverage. Please review.

Project coverage is 29.95%. Comparing base (fc4cc4c) to head (8155af4).
Report is 22 commits behind head on dev.

Files Patch % Lines
...ting-ui/src/components/panel/rule-edit/dataBar.tsx 0.00% 17 Missing ⚠️
...ing/src/services/conditional-formatting.service.ts 25.00% 9 Missing ⚠️
...atting-ui/src/components/hook/useHighlightRange.ts 0.00% 7 Missing ⚠️
...atting-ui/src/components/panel/rule-list/index.tsx 0.00% 7 Missing ⚠️
...atting-ui/src/components/panel/rule-edit/index.tsx 0.00% 4 Missing ⚠️
...matting-ui/src/controllers/cf.render.controller.ts 0.00% 4 Missing ⚠️
...formatting/src/services/calculate-unit/data-bar.ts 57.14% 3 Missing ⚠️
...ting/src/services/calculate-unit/highlight-cell.ts 0.00% 2 Missing ⚠️
...i/src/commands/commands/add-data-bar-cf.command.ts 0.00% 1 Missing ⚠️
...eets-conditional-formatting/src/models/icon-map.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1838      +/-   ##
==========================================
+ Coverage   29.68%   29.95%   +0.27%     
==========================================
  Files        1158     1163       +5     
  Lines       62778    63122     +344     
  Branches    13177    13269      +92     
==========================================
+ Hits        18634    18911     +277     
- Misses      44144    44211      +67     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gggpound Gggpound changed the title Gggpound/feat conditional formatting 0408 feat(conditional-formatting): bugfix Apr 9, 2024
@Gggpound Gggpound force-pushed the gggpound/feat-conditional-formatting-0408 branch from de58bcd to 291c0c4 Compare April 9, 2024 09:40
@Gggpound Gggpound force-pushed the gggpound/feat-conditional-formatting-0408 branch from 291c0c4 to bbe0a53 Compare April 9, 2024 09:42
Copy link

github-actions bot commented Apr 9, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Apr 10, 2024
@Gggpound Gggpound force-pushed the gggpound/feat-conditional-formatting-0408 branch from cbf2792 to 8155af4 Compare April 10, 2024 10:04
@Gggpound Gggpound merged commit c0b3dce into dev Apr 10, 2024
8 checks passed
@Gggpound Gggpound deleted the gggpound/feat-conditional-formatting-0408 branch April 10, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants