Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sheets): refocus sheet cell when create new sheet #1896

Merged
merged 1 commit into from
Apr 15, 2024
Merged

fix(sheets): refocus sheet cell when create new sheet #1896

merged 1 commit into from
Apr 15, 2024

Conversation

Jocs
Copy link
Contributor

@Jocs Jocs commented Apr 13, 2024

close #1677

@Jocs Jocs marked this pull request as ready for review April 13, 2024 09:59
@Jocs Jocs requested review from jikkai and wzhudev as code owners April 13, 2024 09:59
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Apr 13, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 13, 2024 •
edited
Loading

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@codecov Codecov
Copy link

codecov bot commented Apr 13, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 29.53%. Comparing base (04abb1b) to head (1ba17b8).
Report is 13 commits behind head on dev.

Files Patch % Lines
packages/ui/src/services/layout/layout.service.ts 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##              dev    #1896   +/-   ##
=======================================
  Coverage   29.53%   29.53%           
=======================================
  Files        1168     1168           
  Lines       63567    63567           
  Branches    13432    13432           
=======================================
  Hits        18773    18773           
  Misses      44794    44794

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jocs Jocs changed the title fix: refocus sheet cell when create new sheet fix(sheets): refocus sheet cell when create new sheet Apr 13, 2024
@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Apr 15, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Apr 15, 2024
@Jocs Jocs merged commit db88447 into dev Apr 15, 2024
9 checks passed
@Jocs Jocs deleted the fix/refocus-cell branch April 15, 2024 12:41
Gggpound pushed a commit that referenced this pull request Apr 22, 2024
@Jocs @Gggpound
fix: refocus sheet cell when create new sheet (#1896)
311f572
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wzhudev wzhudev wzhudev approved these changes

@jikkai jikkai Awaiting requested review from jikkai jikkai is a code owner

Assignees
No one assigned
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] When creating a new table, the content of the fx column is not cleared
3 participants
@Jocs @wzhudev @zhaolixin7