Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: optimize the the menu and prefer apply-type of auto-fill #2638

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

yuhongz
Copy link
Contributor

@yuhongz yuhongz commented Jun 29, 2024

close https://github.com/dream-num/univer-pro/issues/1265
colse #2597

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@yuhongz yuhongz requested review from jikkai and wzhudev as code owners June 29, 2024 04:33
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Jun 29, 2024
Copy link

codecov bot commented Jun 29, 2024

Codecov Report

Attention: Patch coverage is 72.13115% with 17 lines in your changes missing coverage. Please review.

Project coverage is 27.01%. Comparing base (31c7dbf) to head (c9fc494).
Report is 6 commits behind head on dev.

Files Patch % Lines
packages/sheets-ui/src/services/auto-fill/rules.ts 43.47% 13 Missing ⚠️
.../sheets-ui/src/controllers/auto-fill.controller.ts 90.90% 3 Missing ⚠️
packages/sheets-ui/src/services/auto-fill/tools.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2638      +/-   ##
==========================================
+ Coverage   27.00%   27.01%   +0.01%     
==========================================
  Files        1694     1694              
  Lines       85221    85257      +36     
  Branches    17764    17777      +13     
==========================================
+ Hits        23010    23030      +20     
- Misses      62211    62227      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jun 29, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Jul 1, 2024
@zhaolixin7 zhaolixin7 added qa:untested This PR is ready to be tested and removed qa:rejected labels Jul 2, 2024
@yuhongz yuhongz requested a review from DR-Univer July 2, 2024 03:38
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuhongz yuhongz added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Jul 2, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Jul 2, 2024
@yuhongz yuhongz merged commit b1e1ef4 into dev Jul 2, 2024
9 checks passed
@yuhongz yuhongz deleted the yuhongz/feat-autofill-type branch July 2, 2024 06:19
@jikkai jikkai mentioned this pull request Jul 10, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants