Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(formula): enable cancellation of ongoing formula calculations #2661

Merged
merged 7 commits into from
Jul 9, 2024

Conversation

Dushusir
Copy link
Member

@Dushusir Dushusir commented Jul 2, 2024

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@Dushusir Dushusir marked this pull request as ready for review July 2, 2024 09:33
@univer-bot
Copy link

univer-bot bot commented Jul 2, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

Origin Title: feat(formula): enable cancellation of ongoing formula calculations

Title: feat(formula): enable cancellation of ongoing formula calculations


Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@Dushusir Dushusir added the qa:untested This PR is ready to be tested label Jul 2, 2024
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

Attention: Patch coverage is 67.74194% with 10 lines in your changes missing coverage. Please review.

Project coverage is 26.23%. Comparing base (64264fc) to head (59a728e).

Files Patch % Lines
.../src/controllers/trigger-calculation.controller.ts 0.00% 5 Missing ⚠️
...ges/ui/src/components/progress-bar/ProgressBar.tsx 0.00% 3 Missing ⚠️
...mula/src/engine/value-object/array-value-object.ts 81.81% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2661      +/-   ##
==========================================
- Coverage   26.24%   26.23%   -0.01%     
==========================================
  Files        1684     1684              
  Lines       89173    89168       -5     
  Branches    18783    18784       +1     
==========================================
- Hits        23405    23395      -10     
- Misses      65768    65773       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jul 2, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@zhaolixin7
Copy link

@Dushusir 停止计算后单元格显示公式但未显示结果,控制台有报错
image
2024_7_2 19_53_05 commands.json
2024_7_2 19_53_05 video.webm

@univer-bot
Copy link

univer-bot bot commented Jul 2, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

@Dushusir After stopping the calculation, the cell displays the formula but no result, and an error is reported on the console.
image
2024_7_2 19_53_05 commands.json
2024_7_2 19_53_05 video.webm

@Dushusir
Copy link
Member Author

Dushusir commented Jul 2, 2024

@Dushusir 停止计算后单元格显示公式但未显示结果,控制台有报错 image 2024_7_2 19_53_05 commands.json 2024_7_2 19_53_05 video.webm

fixed

@univer-bot
Copy link

univer-bot bot commented Jul 2, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

@Dushusir Image 409-e80a2144-58df-4b74-b9aa- a61659cf8aca.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUi LCJleHAiOjE3MTk5MjMyNTUsIm5iZiI6MTcxOTkyMjk1NSwicGF0aCI6Ii8xNTQyMDcxMjYvMzQ1 MDExNDA5LWU4MGEyMTQ0LTU4ZGYtNGI3NC1iOWFhLWE2MTY1OWNmOGFjYS5wbmc_WC1BbXotQWxnb 3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1 M1BRSzRaQSUyRjIwMjQwNzAyJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1B bXotRGF0ZT0yMDI0MDcwMlQxMjIyMzVaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT05ZmRiOGRmNDg5MDEzMDAwMzM5MjZlZjMzMTkyNzZlZjBjNTVjNGZjMGZmYz MyZjk5ZDdjM2E0Mzc1ZmFkYWM4JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.KlPnQW7GPnEWN_p6i42CSrQSN3rXD4U-QlC 36-bzB9I) 2024_7_2 19_53_05 commands.json 2024_7_2 19_53_05 video.webm

fixed

@jikkai jikkai requested a review from wzhudev as a code owner July 5, 2024 03:11
@jikkai jikkai changed the title feat(formula): can stop calculate feat(formula): enable cancellation of ongoing formula calculations Jul 5, 2024
@zhaolixin7
Copy link

zhaolixin7 commented Jul 8, 2024

@Dushusir 1、删除引用B c列 2、未计算完时停止计算 3、删除子表,删除子表后点击任意单元格,表现:白屏
2024_7_8 17_26_35 video.webm

@univer-bot
Copy link

univer-bot bot commented Jul 8, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

@Dushusir 1. Delete the reference to column B and c. 2. Stop the calculation before the calculation is completed. 3. Delete the subtable. After deleting the subtable, click on any cell, the performance will be: white screen
2024_7_8 17_26_35 video.webm

@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Jul 8, 2024
@zhaolixin7 zhaolixin7 added qa:verified This PR has already by verified by a QA and is considered good enough to be merge and removed qa:rejected labels Jul 9, 2024
@Dushusir Dushusir merged commit 5d80993 into dev Jul 9, 2024
9 checks passed
@Dushusir Dushusir deleted the dushusir/formula-0702 branch July 9, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] The table freezes after importing
3 participants