Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: backspace in header and footer #2704

Merged
merged 2 commits into from
Jul 7, 2024
Merged

Conversation

Jocs
Copy link
Contributor

@Jocs Jocs commented Jul 6, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@Jocs Jocs marked this pull request as ready for review July 6, 2024 07:20
@Jocs Jocs requested a review from DR-Univer as a code owner July 6, 2024 07:20
@Jocs Jocs requested review from jikkai and weird94 July 6, 2024 07:20
Copy link

codecov bot commented Jul 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 26.50%. Comparing base (14f1f3b) to head (59c1bef).

Files Patch % Lines
...s/docs/src/commands/commands/break-line.command.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #2704   +/-   ##
=======================================
  Coverage   26.50%   26.50%           
=======================================
  Files        1668     1668           
  Lines       89476    89476           
  Branches    18852    18852           
=======================================
  Hits        23719    23719           
  Misses      65757    65757           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jul 6, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@oumomomo oumomomo added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Jul 6, 2024
@Jocs Jocs merged commit 749b407 into dev Jul 7, 2024
9 checks passed
@Jocs Jocs deleted the fix/backspace-in-header-footer branch July 7, 2024 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants