Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs-ui): support docs zoom bar & context menu #2830

Merged
merged 34 commits into from
Jul 25, 2024

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Jul 20, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

codecov bot commented Jul 20, 2024

Codecov Report

Attention: Patch coverage is 0.39841% with 250 lines in your changes missing coverage. Please review.

Project coverage is 26.93%. Comparing base (e6869e4) to head (99f671d).

Files Patch % Lines
...es/docs-ui/src/services/doc-page-layout.service.ts 0.00% 40 Missing ⚠️
...ackages/docs-ui/src/views/count-bar/ZoomSlider.tsx 0.00% 26 Missing ⚠️
...ender-controllers/contextmenu.render-controller.ts 0.00% 23 Missing ⚠️
...kages/docs-ui/src/controllers/doc-ui.controller.ts 0.00% 18 Missing ⚠️
...kages/docs-ui/src/controllers/menu/context-menu.ts 0.00% 18 Missing ⚠️
...cs/text-selection/text-selection-render-manager.ts 0.00% 18 Missing ⚠️
...ommands/operations/show-comment-panel.operation.ts 0.00% 15 Missing ⚠️
...render-controllers/doc-resize.render-controller.ts 0.00% 13 Missing ⚠️
...cs-ui/src/controllers/shortcut/toolbar.shortcut.ts 0.00% 12 Missing ⚠️
.../docs-ui/src/services/doc-popup-manager.service.ts 0.00% 11 Missing ⚠️
... and 14 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2830      +/-   ##
==========================================
- Coverage   26.98%   26.93%   -0.06%     
==========================================
  Files        1784     1792       +8     
  Lines       94229    94428     +199     
  Branches    20135    20156      +21     
==========================================
+ Hits        25432    25433       +1     
- Misses      68797    68995     +198     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jul 20, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@zhaolixin7 zhaolixin7 added the qa:untested This PR is ready to be tested label Jul 22, 2024
@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Jul 25, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Jul 25, 2024
@weird94 weird94 merged commit d840cb5 into dev Jul 25, 2024
9 checks passed
@weird94 weird94 deleted the feat/docs-zoom-context-menu branch July 25, 2024 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants