Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sheet-data-valiation): using cell-raw on data-validation #2878

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Jul 29, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

codecov bot commented Jul 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 27.57%. Comparing base (6b79da6) to head (3a7ab11).
Report is 2 commits behind head on dev.

Files Patch % Lines
...ets-data-validation/src/widgets/checkbox-widget.ts 0.00% 4 Missing ⚠️
...-data-validation/src/views/date-dropdown/index.tsx 0.00% 1 Missing ⚠️
...-data-validation/src/views/list-dropdown/index.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #2878   +/-   ##
=======================================
  Coverage   27.57%   27.57%           
=======================================
  Files        1806     1806           
  Lines       95519    95519           
  Branches    20558    20558           
=======================================
  Hits        26335    26335           
  Misses      69184    69184           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jul 29, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Jul 30, 2024
@weird94 weird94 merged commit 935bdba into dev Jul 30, 2024
9 checks passed
@weird94 weird94 deleted the fix/data-validation-cell-data branch July 30, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants