Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use new selectionData not workbook._worksheetSelections #2909

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

lumixraku
Copy link
Contributor

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.55%. Comparing base (5e09017) to head (6c74417).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2909      +/-   ##
==========================================
- Coverage   27.55%   27.55%   -0.01%     
==========================================
  Files        1821     1821              
  Lines       95939    95938       -1     
  Branches    20524    20524              
==========================================
- Hits        26435    26434       -1     
  Misses      69504    69504              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Aug 2, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@jikkai jikkai merged commit b597194 into dev Aug 2, 2024
9 checks passed
@jikkai jikkai deleted the fix/workbook-selections branch August 2, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants