Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(image): switch tab error #2926

Merged
merged 1 commit into from
Aug 5, 2024
Merged

fix(image): switch tab error #2926

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions packages/drawing-ui/src/controllers/image-update.controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,6 @@ const IMAGE_VIEWER_DROPDOWN_PADDING = 50;

@OnLifecycle(LifecycleStages.Rendered, ImageUpdateController)
export class ImageUpdateController extends Disposable {
private _imageInsertCache: Set<string> = new Set();

constructor(
@ICommandService private readonly _commandService: ICommandService,
@IRenderManagerService private readonly _renderManagerService: IRenderManagerService,
Expand All @@ -57,8 +55,6 @@ export class ImageUpdateController extends Disposable {

override dispose(): void {
super.dispose();

this._imageInsertCache.clear();
}

private _initialize() {
Expand Down Expand Up @@ -213,14 +209,6 @@ export class ImageUpdateController extends Disposable {
return;
}

const drawingShapeKey = getDrawingShapeKeyByDrawingSearch({ unitId, subUnitId, drawingId });

if (this._imageInsertCache.has(drawingShapeKey)) {
return;
}

this._imageInsertCache.add(drawingShapeKey);

const imageParam = this._drawingManagerService.getDrawingByParam(param) as IImageData;
if (imageParam == null) {
return;
Expand Down
Loading