Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(formula): skip tree after add to formula run list #3114

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

Dushusir
Copy link
Member

@Dushusir Dushusir commented Aug 19, 2024

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Aug 19, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Aug 19, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 27.48%. Comparing base (1d7c3ab) to head (2c980f2).
Report is 19 commits behind head on dev.

Files Patch % Lines
...s/core/src/services/snapshot/snapshot-transform.ts 50.00% 1 Missing ⚠️
...ormula/src/engine/dependency/formula-dependency.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3114      +/-   ##
==========================================
- Coverage   27.48%   27.48%   -0.01%     
==========================================
  Files        1981     1981              
  Lines      104966   104967       +1     
  Branches    22653    22653              
==========================================
  Hits        28854    28854              
- Misses      76112    76113       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dushusir Dushusir force-pushed the dushusir/fix-formula-bugs0819 branch from 94b0952 to 95ff00d Compare August 20, 2024 08:17
@Dushusir Dushusir marked this pull request as ready for review August 20, 2024 10:07
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Aug 20, 2024
@Dushusir Dushusir force-pushed the dushusir/fix-formula-bugs0819 branch from b8748c2 to 2c980f2 Compare August 20, 2024 10:12
@Dushusir Dushusir removed the qa:untested This PR is ready to be tested label Aug 20, 2024
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Aug 20, 2024
@oumomomo
Copy link

#2778
计算结果为错误码
image

@univer-bot
Copy link

univer-bot bot commented Aug 22, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

#2778
The calculation result is an error code
image

@oumomomo oumomomo added qa:verified This PR has already by verified by a QA and is considered good enough to be merge and removed qa:untested This PR is ready to be tested labels Aug 22, 2024
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wzhudev wzhudev merged commit a238ea9 into dev Aug 23, 2024
12 checks passed
@wzhudev wzhudev deleted the dushusir/fix-formula-bugs0819 branch August 23, 2024 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
4 participants