Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core)!: remove redundant files in core package #3154

Merged
merged 6 commits into from
Aug 22, 2024
Merged

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Aug 22, 2024

close #xxx

BREAKING CHANGE:

  1. Some useless properties on snapshots are removed: houldStartRenderingImmediately container selections

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@wzhudev wzhudev changed the title refactor: remove redundant files in core package refactor(core)!: remove redundant files in core package Aug 22, 2024
Copy link

github-actions bot commented Aug 22, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 47.31183% with 49 lines in your changes missing coverage. Please review.

Project coverage is 27.63%. Comparing base (9a62d77) to head (c0fcffa).
Report is 3 commits behind head on dev.

Files Patch % Lines
packages/core/src/sheets/typedef.ts 46.47% 38 Missing ⚠️
packages/core/src/sheets/util.ts 33.33% 4 Missing ⚠️
packages/core/src/services/theme/theme.service.ts 0.00% 2 Missing ⚠️
...ollers/render-controllers/doc.render-controller.ts 0.00% 2 Missing ⚠️
packages/core/src/sheets/range.ts 0.00% 1 Missing ⚠️
packages/core/src/univer.ts 85.71% 1 Missing ⚠️
...lers/render-controllers/sheet.render-controller.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3154      +/-   ##
==========================================
+ Coverage   27.61%   27.63%   +0.01%     
==========================================
  Files        1985     1984       -1     
  Lines      105552   105555       +3     
  Branches    22788    22792       +4     
==========================================
+ Hits        29153    29166      +13     
+ Misses      76399    76389      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wzhudev wzhudev marked this pull request as ready for review August 22, 2024 09:34
@wzhudev wzhudev merged commit f08fde6 into dev Aug 22, 2024
9 checks passed
@wzhudev wzhudev deleted the refactor/core branch August 22, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant