Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sheet text #3189

Merged
merged 5 commits into from
Aug 29, 2024
Merged

fix: sheet text #3189

merged 5 commits into from
Aug 29, 2024

Conversation

lumixraku
Copy link
Contributor

@lumixraku lumixraku commented Aug 26, 2024

close https://github.com/dream-num/univer-pro/issues/2225
close https://github.com/dream-num/univer-pro/issues/2215

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Aug 26, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 2.51572% with 155 lines in your changes missing coverage. Please review.

Project coverage is 28.55%. Comparing base (df34611) to head (7316ee5).
Report is 11 commits behind head on dev.

Files with missing lines Patch % Lines
...heets-ui/src/services/selection/selection-shape.ts 0.00% 71 Missing ⚠️
packages/engine-render/src/scene.ts 0.00% 20 Missing ⚠️
.../services/mark-selection/mark-selection.service.ts 10.00% 9 Missing ⚠️
...gine-render/src/components/sheets/column-header.ts 0.00% 8 Missing ⚠️
...i/src/services/selection/mobile-selection-shape.ts 0.00% 8 Missing ⚠️
packages/engine-render/src/layer.ts 0.00% 7 Missing ⚠️
...ervices/selection/base-selection-render.service.ts 0.00% 6 Missing ⚠️
...controllers/sheet-drawing-permission.controller.ts 0.00% 5 Missing ⚠️
...s/render-services/ref-selections.render-service.ts 0.00% 5 Missing ⚠️
...mponents/sheets/extensions/column-header-layout.ts 0.00% 4 Missing ⚠️
... and 9 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3189      +/-   ##
==========================================
- Coverage   28.56%   28.55%   -0.02%     
==========================================
  Files        2022     2022              
  Lines      106770   106837      +67     
  Branches    23101    23110       +9     
==========================================
+ Hits        30503    30509       +6     
- Misses      76267    76328      +61     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Aug 26, 2024
@lumixraku lumixraku requested review from Jocs and removed request for wzhudev and jikkai August 26, 2024 11:14
@oumomomo oumomomo added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Aug 27, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Aug 27, 2024
@lumixraku lumixraku force-pushed the fix/sheet-text branch 2 times, most recently from 82b8349 to 5477e64 Compare August 28, 2024 08:59
@lumixraku lumixraku force-pushed the fix/sheet-text branch 3 times, most recently from 1c6f9bc to d623fbe Compare August 28, 2024 10:01
@lumixraku lumixraku merged commit 5fd5350 into dev Aug 29, 2024
9 checks passed
@lumixraku lumixraku deleted the fix/sheet-text branch August 29, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants