Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(numfmt): add or substract decimal inheritance #3195

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Conversation

Gggpound
Copy link
Contributor

close #1597

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@Gggpound Gggpound requested a review from wzhudev as a code owner August 26, 2024 12:51
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Aug 26, 2024
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Project coverage is 28.63%. Comparing base (d8ca9f6) to head (741d24c).
Report is 1 commits behind head on dev.

Files Patch % Lines
...umfmt/src/commands/commands/add-decimal.command.ts 0.00% 8 Missing ⚠️
.../src/commands/commands/subtract-decimal.command.ts 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3195      +/-   ##
==========================================
- Coverage   28.63%   28.63%   -0.01%     
==========================================
  Files        2024     2024              
  Lines      106969   106985      +16     
  Branches    23120    23126       +6     
==========================================
  Hits        30635    30635              
- Misses      76334    76350      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Aug 27, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@oumomomo oumomomo added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Aug 27, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Aug 27, 2024
@univer-bot univer-bot bot removed the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Aug 27, 2024
@zhaolixin7
Copy link

@Gggpound 常规,多位小数时点击减少小数位会变成一位小数
2024_8_27 11_38_08 video.webm

@univer-bot
Copy link

univer-bot bot commented Aug 27, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

@Gggpound Normally, when there are multiple decimal places, click to reduce the decimal places and it will become one decimal place.
2024_8_27 11_38_08 video.webm

@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Aug 27, 2024
@univer-bot univer-bot bot removed the qa:rejected label Aug 27, 2024
@Gggpound Gggpound merged commit 67f25c8 into dev Aug 27, 2024
9 checks passed
@Gggpound Gggpound deleted the fix-numfmt-0826-2 branch August 27, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
4 participants