Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): boolean values do not need to be processed #3204

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

Gggpound
Copy link
Contributor

close https://github.com/dream-num/univer-pro/issues/2227

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@Gggpound Gggpound requested a review from Jocs as a code owner August 27, 2024 08:20
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Aug 27, 2024
Copy link

github-actions bot commented Aug 27, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.63%. Comparing base (67f25c8) to head (98e4121).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3204   +/-   ##
=======================================
  Coverage   28.63%   28.63%           
=======================================
  Files        2024     2024           
  Lines      106985   106985           
  Branches    23126    23126           
=======================================
  Hits        30635    30635           
  Misses      76350    76350           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Aug 27, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Aug 27, 2024
@Gggpound Gggpound merged commit f060863 into dev Aug 27, 2024
9 checks passed
@Gggpound Gggpound deleted the fix-editor-0827 branch August 27, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants