Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(conditional-formatting): setting highlight error can not be confi… #3229

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

Gggpound
Copy link
Contributor

@Gggpound Gggpound commented Aug 28, 2024

close https://github.com/dream-num/univer-pro/issues/2009

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Aug 28, 2024
Copy link

github-actions bot commented Aug 28, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 28.63%. Comparing base (1899d34) to head (aab3081).
Report is 21 commits behind head on dev.

Files with missing lines Patch % Lines
...i/src/components/panel/rule-edit/highlightCell.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3229   +/-   ##
=======================================
  Coverage   28.63%   28.63%           
=======================================
  Files        2025     2025           
  Lines      106972   106979    +7     
  Branches    23130    23134    +4     
=======================================
+ Hits        30629    30633    +4     
- Misses      76343    76346    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oumomomo oumomomo added qa:verified This PR has already by verified by a QA and is considered good enough to be merge and removed qa:untested This PR is ready to be tested labels Aug 29, 2024
@hexf00 hexf00 added qa:untested This PR is ready to be tested qa:verified This PR has already by verified by a QA and is considered good enough to be merge and removed qa:verified This PR has already by verified by a QA and is considered good enough to be merge qa:untested This PR is ready to be tested labels Aug 29, 2024
@wzhudev wzhudev merged commit 5c16e04 into dev Aug 30, 2024
10 checks passed
@wzhudev wzhudev deleted the fix-cf-0828-2 branch August 30, 2024 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants