-
-
Notifications
You must be signed in to change notification settings - Fork 648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: sheet getRowVisible lags after filter #3396
Conversation
66fb2da
to
c0c2bf1
Compare
View Deployment
|
7a9fdae
to
937c8d9
Compare
937c8d9
to
3f0dc53
Compare
} | ||
return !!this._filteredRowCacheMap.get(row); | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Key changes, add cache for isRowFiltered, intercetor slow down performance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
是interceptor的自身逻辑导致的性能问题?判断是否是filter行,我看底层就是set.has
这样一个逻辑,看起来这个并不是一个高耗时的逻辑。
这个cache的设计,看起来就是单纯为了避免走一次 interptor 自身的逻辑?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rollback 了
chore: revert rowcol visible back
83f44fe
to
feb2eba
Compare
531c945
to
feb2eba
Compare
close #3369
Pull Request Checklist