Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(conditional-formatting): support formatting painter #3420

Merged
merged 3 commits into from
Sep 13, 2024

Conversation

Gggpound
Copy link
Contributor

@Gggpound Gggpound commented Sep 12, 2024

close #3404

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@Gggpound Gggpound changed the title Feat cf painter 0912 feat(conditional-formatting): support formatting painter Sep 12, 2024
Copy link

github-actions bot commented Sep 12, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Sep 12, 2024

Playwright test results

passed  4 passed

Details

stats  4 tests across 2 suites
duration  1 minute, 30 seconds
commit  1c5c495
info  For more information, see full report

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 4.60526% with 145 lines in your changes missing coverage. Please review.

Project coverage is 30.52%. Comparing base (e736b8a) to head (1c5c495).
Report is 3 commits behind head on dev.

Files with missing lines Patch % Lines
...atting-ui/src/controllers/cf.painter.controller.ts 0.00% 144 Missing ⚠️
...ges/sheets-conditional-formatting-ui/src/plugin.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3420      +/-   ##
==========================================
- Coverage   30.56%   30.52%   -0.04%     
==========================================
  Files        2155     2156       +1     
  Lines      112726   112873     +147     
  Branches    24712    24744      +32     
==========================================
  Hits        34458    34458              
- Misses      78268    78415     +147     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gggpound Gggpound force-pushed the feat-cf-painter-0912 branch 2 times, most recently from fbd854a to 4505bf3 Compare September 13, 2024 07:14
@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Sep 13, 2024
@Gggpound Gggpound merged commit 2b121d7 into dev Sep 13, 2024
9 checks passed
@Gggpound Gggpound deleted the feat-cf-painter-0912 branch September 13, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] After setting conditional formatting, using Format Painter does not take effect.
3 participants