Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sheet): group sheet get cell intercptor to performance well #3534

Merged
merged 3 commits into from
Sep 26, 2024
Merged

feat(sheet): group sheet get cell intercptor to performance well #3534

merged 3 commits into from
Sep 26, 2024

Conversation

VicKun4937
Copy link
Contributor

  • refactor cell inerceptor

@VicKun4937 VicKun4937 marked this pull request as draft September 23, 2024 08:11
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 23, 2024 •
edited
Loading

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 23, 2024 •
edited
Loading

Playwright test results

passed  8 passed

Details

stats  8 tests across 3 suites
duration  2 minutes, 11 seconds
commit  8dc3366
info  For more information, see full report

wzhudev
wzhudev approved these changes Sep 23, 2024
View reviewed changes
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov Codecov
Copy link

codecov bot commented Sep 23, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 41.26984% with 37 lines in your changes missing coverage. Please review.

Project coverage is 31.84%. Comparing base (0ab07d9) to head (8dc3366).
Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
packages/core/src/common/interceptor.ts 21.42% 11 Missing ⚠️
packages/core/src/sheets/view-model.ts 11.11% 8 Missing ⚠️
packages/core/src/sheets/worksheet.ts 0.00% 8 Missing ⚠️
...ers/permission/sheet-permission-init.controller.ts 0.00% 3 Missing ⚠️
...es/sheets/src/model/range-protection-rule.model.ts 0.00% 3 Missing ⚠️
.../src/controllers/numfmt.cell-content.controller.ts 66.66% 2 Missing ⚠️
...sheets-numfmt/src/controllers/numfmt.controller.ts 0.00% 1 Missing ⚠️
packages/sheets-numfmt/src/utils/pattern.ts 80.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #3534      +/-   ##
==========================================
- Coverage   31.84%   31.84%   -0.01%     
==========================================
  Files        2194     2194              
  Lines      115259   115301      +42     
  Branches    25383    25397      +14     
==========================================
+ Hits        36706    36719      +13     
- Misses      78553    78582      +29
Flag Coverage Δ
31.84% <41.26%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VicKun4937
Copy link
Contributor Author

image

It seems not solve the performance issue, because the number format is a intercepror change style and value both?

should we contiue this draft code

@VicKun4937 VicKun4937 force-pushed the refactor-cell-inerceptor branch from 10bc95c to 980bcd4 Compare September 25, 2024 03:54
@VicKun4937 VicKun4937 changed the title feat(sheet): draft code feat(sheet): group sheet get cell intercptor to performance well Sep 25, 2024
@VicKun4937 VicKun4937 force-pushed the refactor-cell-inerceptor branch 3 times, most recently from 9a9cd70 to fb9b8c4 Compare September 25, 2024 12:24
VicKun4937
VicKun4937 commented Sep 25, 2024
View reviewed changes
packages/core/src/sheets/view-model.ts
return this.getRawCell(row, col);
}

getCellStyleOnly(row: number, col: number): Nullable<ICellDataForSheetInterceptor> {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lumixraku here , after merged this pr, you can use above two api in sketon to get better performance

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge now?

@VicKun4937 VicKun4937 force-pushed the refactor-cell-inerceptor branch from c10f7cd to e786182 Compare September 26, 2024 02:57
@VicKun4937 VicKun4937 marked this pull request as ready for review September 26, 2024 02:57
@VicKun4937 VicKun4937 merged commit ab97ea1 into dev Sep 26, 2024
9 checks passed
@VicKun4937 VicKun4937 deleted the refactor-cell-inerceptor branch September 26, 2024 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lumixraku lumixraku lumixraku left review comments

@Dushusir Dushusir Dushusir approved these changes

@wzhudev wzhudev wzhudev approved these changes

@ybzky ybzky Awaiting requested review from ybzky ybzky is a code owner

@yuhongz yuhongz Awaiting requested review from yuhongz yuhongz is a code owner

@Gggpound Gggpound Awaiting requested review from Gggpound Gggpound is a code owner

@DR-Univer DR-Univer Awaiting requested review from DR-Univer DR-Univer is a code owner

@jikkai jikkai Awaiting requested review from jikkai jikkai is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@VicKun4937 @lumixraku @wzhudev @Dushusir