Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support sheet paste customRange #3537

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

fix: support sheet paste customRange #3537

wants to merge 2 commits into from

Conversation

ybzky
Copy link
Member

@ybzky ybzky commented Sep 23, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Sep 23, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Sep 23, 2024

Playwright test results

passed  4 passed

Details

stats  4 tests across 2 suites
duration  1 minute, 23 seconds
commit  ab972b3
info  For more information, see full report

@ybzky ybzky added the qa:untested This PR is ready to be tested label Sep 23, 2024
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 18.51852% with 22 lines in your changes missing coverage. Please review.

Project coverage is 30.90%. Comparing base (ed6d783) to head (ab972b3).
Report is 19 commits behind head on dev.

Files with missing lines Patch % Lines
packages/core/src/shared/clipboard.ts 0.00% 21 Missing ⚠️
...ui/src/services/clipboard/html-to-usm/converter.ts 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3537      +/-   ##
==========================================
- Coverage   30.94%   30.90%   -0.05%     
==========================================
  Files        2159     2161       +2     
  Lines      113371   113538     +167     
  Branches    24873    24898      +25     
==========================================
+ Hits        35078    35084       +6     
- Misses      78293    78454     +161     
Flag Coverage Δ
30.90% <18.51%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Sep 23, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Sep 23, 2024

let cursorIndex = startIndex;
let html = '';
customRangesInRange.forEach((range) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking about extensibility, what features should be builtin here? What about other features like mentions, extensions etc.?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants