-
-
Notifications
You must be signed in to change notification settings - Fork 714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: dispose and createUnit cause viewport height collapse #3598
Conversation
View Deployment
|
Playwright test resultsDetails 8 tests across 3 suites |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #3598 +/- ##
=======================================
Coverage 31.84% 31.84%
=======================================
Files 2194 2194
Lines 115314 115314
Branches 25401 25401
=======================================
Hits 36719 36719
Misses 78595 78595
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
e4950ec
to
f73bd42
Compare
close #3555
Way to reproduce this issue:
first
univerAPI.disposeUnit('workbook-01')
then
univerAPI.createUniverSheet()
Pull Request Checklist