Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(float-image): support paste image from external #3617

Open
wants to merge 9 commits into
base: dev
Choose a base branch
from

Conversation

siam-ese
Copy link
Contributor

close #2623

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Sep 28, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@siam-ese siam-ese added the qa:untested This PR is ready to be tested label Sep 28, 2024
Copy link

github-actions bot commented Sep 28, 2024

Playwright test results

passed  11 passed

Details

stats  11 tests across 5 suites
duration  2 minutes, 49 seconds
commit  62077fc
info  For more information, see full report

Copy link

codecov bot commented Sep 28, 2024

Codecov Report

Attention: Patch coverage is 9.83607% with 165 lines in your changes missing coverage. Please review.

Project coverage is 31.77%. Comparing base (1964a4c) to head (62077fc).
Report is 32 commits behind head on dev.

Files with missing lines Patch % Lines
...controllers/sheet-drawing-copy-paste.controller.ts 0.00% 129 Missing ⚠️
...g-ui/src/commands/commands/insert-image.command.ts 0.00% 10 Missing ⚠️
.../src/controllers/clipboard/clipboard.controller.ts 0.00% 9 Missing ⚠️
...ets-ui/src/services/clipboard/clipboard.service.ts 66.66% 9 Missing ⚠️
...src/controllers/sheet-drawing-update.controller.ts 0.00% 3 Missing ⚠️
...ing-ui/src/controllers/sheet-drawing.controller.ts 0.00% 3 Missing ⚠️
...eets-ui/src/commands/commands/clipboard.command.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3617      +/-   ##
==========================================
- Coverage   31.87%   31.77%   -0.10%     
==========================================
  Files        2193     2225      +32     
  Lines      115294   115773     +479     
  Branches    25402    25487      +85     
==========================================
+ Hits        36745    36786      +41     
- Misses      78549    78987     +438     
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhaolixin7
Copy link

zhaolixin7 commented Sep 28, 2024

@siam-ese 编辑图片(修改图片大小、修改面板中的内容),然后复制内容后粘贴,表现:粘贴失败2024_9_28 19_21_54 commands.json
2024_9_28 19_21_54 video.webm

@univer-bot
Copy link

univer-bot bot commented Sep 28, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

@siam-ese edits the image (modify the image size, modify the content in the panel), then copy the content and paste it, the performance is: paste failed [2024_9_28 19_21_54 commands.json](https://github.com/user-attachments/files/ 17174208/2024_9_28.19_21_54.commands.json)
2024_9_28 19_21_54 video.webm

@dream-num dream-num deleted a comment from univer-bot bot Sep 28, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Sep 28, 2024
@zhaolixin7
Copy link

zhaolixin7 commented Sep 29, 2024

@siam-ese 问题1、锚点属性跟随移动和改变大小,剪切单元格后撤销,表现:图片消失了;--粘贴的问题
问题2、首次刷新后复制图片,表现:粘贴失败,有时会进入编辑态
https://github.com/user-attachments/assets/4f980e15-8af6-4f12-9dd1-1c51f2c00a6c

问题3:剪切图片后粘贴,表现:源图片未消失

@univer-bot
Copy link

univer-bot bot commented Sep 29, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

@siam-ese Problem 1. The anchor point attribute follows the movement and changes in size. When the cell is cut and then undo, the performance: the picture disappears; --paste problem
Question 2. When copying a picture after refreshing for the first time, the performance: the paste fails and sometimes it enters the editing state.
https://github.com/user-attachments/assets/4f980e15-8af6-4f12-9dd1-1c51f2c00a6c

Problem 3: After cutting the picture and pasting it, the performance: the source picture does not disappear

@zhaolixin7 zhaolixin7 added qa:rejected and removed qa:untested This PR is ready to be tested labels Oct 8, 2024
@zhaolixin7
Copy link

@siam-ese 问题2表格未加在完是复制图片粘贴后还是会进入编辑态
https://github.com/user-attachments/assets/f6408e32-6ae4-48f6-a438-0e9c1fd61473

问题3:剪切后多次粘贴,表现:只保留最后一次的图片 (飞书和Excel是剪切图片后多次粘贴都显示)
预期:参考飞书和Excel还是剪切后只能粘贴一次对照我们的文本?
https://github.com/user-attachments/assets/927726ea-d4bc-494c-866c-32450327b586

新增:问题4;选中图片后无法修改列宽、行高
2024_10_8 14_58_35 video.webm

@univer-bot
Copy link

univer-bot bot commented Oct 8, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

@siam-ese Question 2: The table is not added. Will it still enter the editing state after copying and pasting the image?
https://github.com/user-attachments/assets/f6408e32-6ae4-48f6-a438-0e9c1fd61473

Question 3: After cutting and pasting multiple times, the performance: only the last picture is retained (Feishu and Excel show that after cutting the picture and pasting it multiple times)
Expectation: Refer to Feishu and Excel or only cut and paste once to compare our text?
https://github.com/user-attachments/assets/927726ea-d4bc-494c-866c-32450327b586

New: Issue 4; Column width and row height cannot be modified after selecting a picture
2024_10_8 14_58_35 video.webm

@zhaolixin7 zhaolixin7 added qa:verified This PR has already by verified by a QA and is considered good enough to be merge and removed qa:rejected labels Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Floating images support copy and paste
2 participants