Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(permission): add row and column cache to optimize performance #3634

Merged
merged 5 commits into from
Oct 9, 2024

Conversation

ybzky
Copy link
Member

@ybzky ybzky commented Sep 29, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Sep 29, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Sep 29, 2024

Playwright test results

failed  1 failed
passed  10 passed

Details

stats  11 tests across 5 suites
duration  3 minutes, 18 seconds
commit  9df455c
info  For more information, see full report

Failed tests

chromium › visual-comparison/sheet/sheets-visual-comparison.spec.ts › diff demo sheet content

Copy link

codecov bot commented Sep 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 112 lines in your changes missing coverage. Please review.

Project coverage is 31.77%. Comparing base (f0252ca) to head (9df455c).
Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
...ackages/sheets/src/model/range-protection.cache.ts 0.00% 96 Missing ⚠️
...permission-interceptor-canvas-render.controller.ts 0.00% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3634      +/-   ##
==========================================
- Coverage   31.80%   31.77%   -0.03%     
==========================================
  Files        2225     2225              
  Lines      115648   115746      +98     
  Branches    25462    25489      +27     
==========================================
  Hits        36777    36777              
- Misses      78871    78969      +98     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wzhudev
Copy link
Member

wzhudev commented Oct 8, 2024

The title of this pull request shall be changed to better summarize what have been changed.

@ybzky ybzky added the qa:untested This PR is ready to be tested label Oct 8, 2024
@ybzky ybzky requested a review from VicKun4937 as a code owner October 8, 2024 09:31
@ybzky ybzky changed the title perf: fix header perf perf(permission): add row and column cache to optimize performance Oct 8, 2024
@ybzky ybzky force-pushed the fix-permission-header-perf branch from 95d491c to ee22d5b Compare October 8, 2024 09:48
@ybzky ybzky force-pushed the fix-permission-header-perf branch from ee22d5b to 6560a22 Compare October 9, 2024 03:42
@ybzky
Copy link
Member Author

ybzky commented Oct 9, 2024

/update-snapshots

@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Oct 9, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Oct 9, 2024
@ybzky ybzky merged commit 27eb2a3 into dev Oct 9, 2024
2 checks passed
@ybzky ybzky deleted the fix-permission-header-perf branch October 9, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants