Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(formula): array formula spill error #3673

Merged
merged 2 commits into from
Oct 11, 2024
Merged

Conversation

Dushusir
Copy link
Member

@Dushusir Dushusir commented Oct 9, 2024

close https://github.com/dream-num/univer-pro/issues/2418

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@Dushusir Dushusir marked this pull request as ready for review October 9, 2024 13:18
@Dushusir Dushusir requested a review from wzhudev as a code owner October 9, 2024 13:18
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Oct 9, 2024
@Dushusir Dushusir force-pushed the dushusir/formula-bugs1008 branch from 9ef408e to 1843ce7 Compare October 9, 2024 13:19
Copy link

github-actions bot commented Oct 9, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Oct 9, 2024

Playwright test results

passed  13 passed
flaky  1 flaky

Details

stats  14 tests across 8 suites
duration  3 minutes, 51 seconds
commit  13eb001
info  For more information, see full report

Flaky tests

chromium › memory/memory.spec.ts › memory

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 29.16667% with 34 lines in your changes missing coverage. Please review.

Project coverage is 31.13%. Comparing base (6f03566) to head (13eb001).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...ges/engine-formula/src/services/runtime.service.ts 0.00% 25 Missing ⚠️
...gine-formula/src/models/utils/formula-data-util.ts 64.70% 6 Missing ⚠️
...ngine-formula/src/services/current-data.service.ts 60.00% 2 Missing ⚠️
...ine-formula/src/controller/calculate.controller.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3673      +/-   ##
==========================================
- Coverage   31.13%   31.13%   -0.01%     
==========================================
  Files        2254     2254              
  Lines      116642   116685      +43     
  Branches    25632    25642      +10     
==========================================
+ Hits        36315    36326      +11     
- Misses      80327    80359      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oumomomo oumomomo added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Oct 10, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Oct 10, 2024
@Dushusir Dushusir force-pushed the dushusir/formula-bugs1008 branch 2 times, most recently from 9d6ae5f to 535cd6c Compare October 10, 2024 10:16
@Dushusir Dushusir force-pushed the dushusir/formula-bugs1008 branch from 1a649de to 13eb001 Compare October 11, 2024 05:35
@Dushusir Dushusir merged commit e8ffd23 into dev Oct 11, 2024
9 checks passed
@Dushusir Dushusir deleted the dushusir/formula-bugs1008 branch October 11, 2024 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants