Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add replay-only mode to actionRecordPlugin #3695

Merged
merged 2 commits into from
Oct 10, 2024
Merged

feat: add replay-only mode to actionRecordPlugin #3695

merged 2 commits into from
Oct 10, 2024

Conversation

yuhongz
Copy link
Contributor

@yuhongz yuhongz commented Oct 10, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Oct 10, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

Playwright test results

passed  11 passed

Details

stats  11 tests across 5 suites
duration  2 minutes, 49 seconds
commit  344bee4
info  For more information, see full report

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 31.12%. Comparing base (a2f2215) to head (344bee4).
Report is 5 commits behind head on dev.

Files with missing lines Patch % Lines
...ackages-experimental/action-recorder/src/plugin.ts 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3695      +/-   ##
==========================================
- Coverage   31.12%   31.12%   -0.01%     
==========================================
  Files        2250     2250              
  Lines      116232   116236       +4     
  Branches    25579    25582       +3     
==========================================
  Hits        36176    36176              
- Misses      80056    80060       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yuhongz yuhongz requested a review from wzhudev October 10, 2024 11:35
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuhongz yuhongz merged commit a3cb5c4 into dev Oct 10, 2024
9 checks passed
@yuhongz yuhongz deleted the feat/replay branch October 10, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants