Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheets-ui): error quit edit when set-range-values was called #3697

Merged
merged 19 commits into from
Oct 12, 2024

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Oct 10, 2024

close https://github.com/dream-num/univer-pro/issues/2780
close #3374
close https://github.com/dream-num/univer-pro/issues/1696
close #3591
close https://github.com/dream-num/univer-pro/issues/2717

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@weird94 weird94 requested a review from Jocs as a code owner October 10, 2024 12:06
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Oct 10, 2024
Copy link

github-actions bot commented Oct 10, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Oct 10, 2024

Playwright test results

passed  16 passed

Details

stats  16 tests across 8 suites
duration  3 minutes, 59 seconds
commit  99c61a7
info  For more information, see full report

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 118 lines in your changes missing coverage. Please review.

Project coverage is 31.25%. Comparing base (7ed4212) to head (99c61a7).
Report is 5 commits behind head on dev.

Files with missing lines Patch % Lines
...rc/controllers/editor/editing.render-controller.ts 0.00% 75 Missing ⚠️
...es/sheets-ui/src/services/editor-bridge.service.ts 0.00% 34 Missing ⚠️
...c/commands/operations/scroll-to-range.operation.ts 0.00% 3 Missing ⚠️
...-ui/src/views/editor-container/EditorContainer.tsx 0.00% 3 Missing ⚠️
...ers/render-controllers/scroll.render-controller.ts 0.00% 2 Missing ⚠️
...rc/commands/operations/text-selection.operation.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3697      +/-   ##
==========================================
- Coverage   31.26%   31.25%   -0.02%     
==========================================
  Files        2263     2263              
  Lines      117387   117484      +97     
  Branches    25842    25866      +24     
==========================================
+ Hits        36703    36714      +11     
- Misses      80684    80770      +86     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oumomomo
Copy link

https://github.com/dream-num/univer-pro/issues/2780
点击超长单元格的最上方,编辑框异常
2024_10_10 20_38_36 video.webm
image

@univer-bot
Copy link

univer-bot bot commented Oct 10, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

https://github.com/dream-num/univer-pro/issues/2780
Clicking on the top of a very long cell causes an abnormality in the edit box.
2024_10_10 20_38_36 video.webm
image

@weird94
Copy link
Contributor Author

weird94 commented Oct 10, 2024

2024_10_10 20_38_36 video.webm

fixed

@oumomomo
Copy link

#3374

在单元格内输入横向的超长内容,点击fx栏,编辑框内容展示不全
2024_10_11 11_14_06 video.webm

@univer-bot
Copy link

univer-bot bot commented Oct 11, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

#3374

Enter horizontally long content in the cell and click the fx column. The content of the edit box is not fully displayed.
2024_10_11 11_14_06 video.webm

@univer-bot
Copy link

univer-bot bot commented Oct 11, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

Unable to write content via fx bar
2024_10_11 11_16_54 video.webm

@oumomomo oumomomo added qa:rejected and removed qa:untested This PR is ready to be tested labels Oct 11, 2024
@weird94
Copy link
Contributor Author

weird94 commented Oct 11, 2024

无法通过fx栏写入内容 2024_10_11 11_16_54 video.webm

fixed

@univer-bot
Copy link

univer-bot bot commented Oct 11, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

Unable to write content via fx bar 2024_10_11 11_16_54 video.webm

fixed

@weird94 weird94 added qa:untested This PR is ready to be tested and removed qa:rejected labels Oct 11, 2024
@weird94 weird94 changed the title fix(sheets-ui): should scroll editor into view fix(sheets-ui): error quit edit when set-range-values was called Oct 12, 2024
@weird94 weird94 removed the qa:untested This PR is ready to be tested label Oct 12, 2024
@weird94 weird94 merged commit 0c29785 into dev Oct 12, 2024
15 checks passed
@weird94 weird94 deleted the fix/scroll-editor-into-view branch October 12, 2024 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] App freezes due to high frequency changes [Bug] cell editor overflows
3 participants