Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): fix missing context menu items #3758

Merged
merged 2 commits into from
Oct 15, 2024
Merged

fix(ui): fix missing context menu items #3758

merged 2 commits into from
Oct 15, 2024

Conversation

jikkai
Copy link
Member

@jikkai jikkai commented Oct 15, 2024

close https://github.com/dream-num/univer-pro/issues/2877

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Oct 15, 2024
Copy link

github-actions bot commented Oct 15, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Oct 15, 2024

Playwright test results

failed  1 failed
passed  16 passed

Details

stats  17 tests across 8 suites
duration  4 minutes, 46 seconds
commit  41b0ece
info  For more information, see full report

Failed tests

chromium › visual-comparison/docs/docs-visual-comparison.spec.ts › diff default doc content

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 31.00%. Comparing base (e16ead3) to head (41b0ece).

Files with missing lines Patch % Lines
packages/ui/src/components/menu/desktop/Menu.tsx 0.00% 8 Missing ⚠️
...kages/docs-ui/src/controllers/menu/context-menu.ts 0.00% 1 Missing ⚠️
...ui/src/services/confirm/desktop-confirm.service.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3758      +/-   ##
==========================================
- Coverage   31.00%   31.00%   -0.01%     
==========================================
  Files        2280     2280              
  Lines      118356   118359       +3     
  Branches    26088    26088              
==========================================
  Hits        36693    36693              
- Misses      81663    81666       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Oct 15, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Oct 15, 2024
@jikkai jikkai merged commit 421d009 into dev Oct 15, 2024
2 checks passed
@jikkai jikkai deleted the fix/missing-menu branch October 15, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants