Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix type-check #3796

Merged
merged 1 commit into from
Oct 18, 2024
Merged

fix: fix type-check #3796

merged 1 commit into from
Oct 18, 2024

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Oct 18, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Oct 18, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

Playwright test results

passed  16 passed
flaky  1 flaky

Details

stats  17 tests across 8 suites
duration  4 minutes, 32 seconds
commit  6f1f333
info  For more information, see full report

Flaky tests

chromium › visual-comparison/sheets/sheets-visual-comparison.spec.ts › diff default sheet toolbar

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 30.97%. Comparing base (8978364) to head (6f1f333).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3796   +/-   ##
=======================================
  Coverage   30.97%   30.97%           
=======================================
  Files        2285     2285           
  Lines      118732   118732           
  Branches    26171    26171           
=======================================
  Hits        36782    36782           
  Misses      81950    81950           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wzhudev wzhudev merged commit cc822fa into dev Oct 18, 2024
9 checks passed
@wzhudev wzhudev deleted the fix/type-check branch October 18, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant