Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rich text conflict with cf #3941

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix: rich text conflict with cf #3941

wants to merge 1 commit into from

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Nov 2, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Nov 2, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Nov 2, 2024

Playwright test results

failed  2 failed
passed  17 passed

Details

stats  19 tests across 9 suites
duration  5 minutes, 22 seconds
commit  34e5636
info  For more information, see full report

Failed tests

chromium › visual-comparison/sheets/sheets-visual-comparison.spec.ts › diff merged cells rendering
chromium › visual-comparison/sheets/sheets-visual-comparison.spec.ts › diff merged cells rendering after scrolling

Copy link

codecov bot commented Nov 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 32.33%. Comparing base (05339d2) to head (34e5636).

Files with missing lines Patch % Lines
...ine-render/src/components/sheets/sheet-skeleton.ts 0.00% 12 Missing ⚠️
...es/sheets-ui/src/services/editor-bridge.service.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3941   +/-   ##
=======================================
  Coverage   32.33%   32.33%           
=======================================
  Files        2458     2458           
  Lines      125935   125933    -2     
  Branches    28126    28125    -1     
=======================================
  Hits        40717    40717           
+ Misses      85218    85216    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants