-
-
Notifications
You must be signed in to change notification settings - Fork 724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sheet): parseValue handle number #4049
Conversation
View Deployment
|
Playwright test resultsDetails
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #4049 +/- ##
=======================================
Coverage 33.76% 33.76%
=======================================
Files 2486 2486
Lines 127614 127615 +1
Branches 28584 28585 +1
=======================================
+ Hits 43092 43093 +1
Misses 84522 84522 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should add a unit test for the situation numfmt.isDate()
is true.
In this test, expect(normalizeStringByLexer('=SUM(11, 2 2, 33)')).toBe('=SUM(11, 2 2, 33)'); Execution details numfmt.parseValue('2 2') // Get { "v": 45324, "z": "m d"}
numfmt.isDate('m d') // Get true |
46b7a35
to
0b0b7a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What's updated?
Fix parse cell input
How to test?
=SUM(11, 2 2, 33)
in the Cell=SUM(11, 2 2, 33)
(Previously it was correctly coverted to=SUM(11, 45324, 33)
)Pull Request Checklist