Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: prepare for formula refactor #4064

Draft
wants to merge 6 commits into
base: dev
Choose a base branch
from
Draft

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Nov 14, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Nov 14, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Nov 14, 2024

Playwright test results

passed  19 passed

Details

stats  19 tests across 9 suites
duration  4 minutes, 39 seconds
commit  dc1e7ac
info  For more information, see full report

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 32.97%. Comparing base (820653c) to head (dc1e7ac).
Report is 7 commits behind head on dev.

Files with missing lines Patch % Lines
...rmula/src/services/active-dirty-manager.service.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4064      +/-   ##
==========================================
+ Coverage   32.95%   32.97%   +0.02%     
==========================================
  Files        2497     2496       -1     
  Lines      126919   126832      -87     
  Branches    28419    28375      -44     
==========================================
+ Hits        41821    41826       +5     
+ Misses      85098    85006      -92     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wzhudev wzhudev force-pushed the refactor/prepare-formula branch 2 times, most recently from f0f3af9 to 29d16de Compare November 14, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant