Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheets-formula): other formula register #4073

Merged
merged 7 commits into from
Nov 15, 2024
Merged

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Nov 15, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Nov 15, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Nov 15, 2024

Playwright test results

failed  1 failed
passed  18 passed

Details

stats  19 tests across 9 suites
duration  5 minutes, 38 seconds
commit  f746e4a
info  For more information, see full report

Failed tests

chromium › memory/memory.spec.ts › memory

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 32.99%. Comparing base (9ccdf2a) to head (f746e4a).
Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
...ula/src/services/register-other-formula.service.ts 0.00% 6 Missing ⚠️
.../src/controllers/trigger-calculation.controller.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4073      +/-   ##
==========================================
- Coverage   32.99%   32.99%   -0.01%     
==========================================
  Files        2437     2437              
  Lines      126777   126781       +4     
  Branches    28377    28377              
==========================================
  Hits        41826    41826              
- Misses      84951    84955       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dushusir
Copy link
Member

Note Playwright Tests

@weird94 weird94 merged commit 403381b into dev Nov 15, 2024
8 of 9 checks passed
@weird94 weird94 deleted the fix/other-formula-register branch November 15, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants