Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move dayjs into @univerjs/core #4078

Merged
merged 1 commit into from
Nov 15, 2024
Merged

refactor: move dayjs into @univerjs/core #4078

merged 1 commit into from
Nov 15, 2024

Conversation

jikkai
Copy link
Member

@jikkai jikkai commented Nov 15, 2024

close #3857

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Nov 15, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Nov 15, 2024

Playwright test results

passed  19 passed

Details

stats  19 tests across 9 suites
duration  4 minutes, 39 seconds
commit  24f30e0
info  For more information, see full report

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 32.99%. Comparing base (d3085e2) to head (24f30e0).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...s/design/src/components/date-picker/DatePicker.tsx 0.00% 1 Missing ⚠️
...c/components/date-range-picker/DateRangePicker.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #4078   +/-   ##
=======================================
  Coverage   32.98%   32.99%           
=======================================
  Files        2437     2437           
  Lines      126786   126786           
  Branches    28380    28380           
=======================================
+ Hits        41826    41833    +7     
+ Misses      84960    84953    -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jikkai jikkai merged commit 859907c into dev Nov 15, 2024
9 checks passed
@jikkai jikkai deleted the refactor/dayjs branch November 15, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] White screen error after selecting date format during data verification
1 participant