Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(formula): init trigger calculation controller on rendered #4118

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

Dushusir
Copy link
Member

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Nov 21, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Nov 21, 2024

Playwright test results

passed  20 passed

Details

stats  20 tests across 9 suites
duration  4 minutes, 50 seconds
commit  8822b4f
info  For more information, see full report

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 33.76%. Comparing base (2547183) to head (8822b4f).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...ckages/sheets-formula/src/sheets-formula.plugin.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4118      +/-   ##
==========================================
- Coverage   33.76%   33.76%   -0.01%     
==========================================
  Files        2457     2457              
  Lines      127772   127774       +2     
  Branches    28612    28613       +1     
==========================================
  Hits        43141    43141              
- Misses      84631    84633       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@Dushusir Dushusir merged commit 9e7b9fb into dev Nov 22, 2024
9 checks passed
@Dushusir Dushusir deleted the dushusir/init-trigger-cal branch November 22, 2024 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants