Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: no reuse border #4138

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from
Open

fix: no reuse border #4138

wants to merge 6 commits into from

Conversation

lumixraku
Copy link
Contributor

@lumixraku lumixraku commented Nov 23, 2024

close https://github.com/dream-num/univer-pro/issues/3016

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Nov 23, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@lumixraku lumixraku marked this pull request as ready for review November 23, 2024 12:36
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Nov 23, 2024
Copy link

github-actions bot commented Nov 23, 2024

Playwright test results

failed  1 failed
passed  19 passed

Details

stats  20 tests across 9 suites
duration  5 minutes, 46 seconds
commit  d601bd7
info  For more information, see full report

Failed tests

chromium › memory/memory.spec.ts › memory

Copy link

codecov bot commented Nov 23, 2024

Codecov Report

Attention: Patch coverage is 56.52174% with 20 lines in your changes missing coverage. Please review.

Project coverage is 33.74%. Comparing base (798e1fd) to head (d601bd7).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...tion-ui/src/controllers/dv-auto-fill.controller.ts 0.00% 9 Missing ⚠️
packages/core/src/sheets/worksheet.ts 0.00% 5 Missing ⚠️
...n/src/commands/commands/data-validation.command.ts 0.00% 3 Missing ⚠️
...ckages/sheets-data-validation/src/utils/formula.ts 0.00% 2 Missing ⚠️
...mmands/commands/insert-range-move-right.command.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #4138   +/-   ##
=======================================
  Coverage   33.74%   33.74%           
=======================================
  Files        2457     2457           
  Lines      127861   127894   +33     
  Branches    28631    28637    +6     
=======================================
+ Hits        43141    43154   +13     
- Misses      84720    84740   +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@oumomomo
Copy link

oumomomo commented Nov 25, 2024

选中上下两个单元格分别设置边框,选中第二个单元格使用插入-右移/下移
实际表现:下移/右移后上方的单元格边框 不完整
image
2024_11_25 10_53_33 video.webm

@univer-bot
Copy link

univer-bot bot commented Nov 25, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

Select the upper and lower cells to set borders respectively, select the second cell and use Insert-Move Right/Move Down
Actual performance: The upper cell border is incomplete after moving down/right
image
2024_11_25 10_53_33 video.webm

@oumomomo
Copy link

oumomomo commented Nov 25, 2024

选中A1&A2&A4 三个单元格设置边框,选中A3单元格使用在上方插入行
实际表现:新增的单元格有边框
预期表现:新增的单元格无边框
2024_11_25 11_01_35 video.webm
左边为univer,右边为excel
企业微信截图_17325037518001

@univer-bot
Copy link

univer-bot bot commented Nov 25, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

Select the three cells A1&A2&A4 to set borders, and select the A3 cell to insert a row above.
Actual performance: The newly added cells have borders
Expected performance: New cells have no borders
2024_11_25 11_01_35 video.webm
Univer is on the left and excel is on the right
Enterprise WeChat screenshot_17325037518001

@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Nov 25, 2024
@oumomomo
Copy link

在A1、B2、C1单元格使用边框线,选中B列左边插入列
预期表现:新增的列不会有边框线
实际表现:新增的列会有边框线
2024_11_25 11_13_20 video.webm
左侧为univer,右侧为excel
image

@univer-bot
Copy link

univer-bot bot commented Nov 25, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

Use border lines in cells A1, B2, and C1, select the left side of column B and insert a column
Expected performance: New columns will not have borders
Actual performance: The newly added columns will have border lines
2024_11_25 11_13_20 video.webm
Univer is on the left and excel is on the right
image

@oumomomo
Copy link

oumomomo commented Nov 25, 2024

选中A1、B1两个单元格设置边框,选中A列使用插入列(插入行也有这个问题)
预期表现:新增的单元格有边框
实际表现:新增的单元格无边框
image
image
2024_11_25 11_29_39 video.webm

@univer-bot
Copy link

univer-bot bot commented Nov 25, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

Select cells A1 and B1 to set borders, select column A and use insert column (insert row also has this problem)
Expected performance: New cells have borders
Actual performance: The newly added cells have no borders
image
image
2024_11_25 11_29_39 video.webm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants