Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(conditional-formatting): memory leak #4212

Merged
merged 2 commits into from
Dec 3, 2024
Merged

fix(conditional-formatting): memory leak #4212

merged 2 commits into from
Dec 3, 2024

Conversation

Gggpound
Copy link
Contributor

@Gggpound Gggpound commented Dec 3, 2024

close https://github.com/dream-num/univer-pro/issues/3642

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Dec 3, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

github-actions bot commented Dec 3, 2024

Playwright test results

failed  1 failed
passed  18 passed
flaky  1 flaky

Details

stats  20 tests across 9 suites
duration  5 minutes, 48 seconds
commit  fdc8547
info  For more information, see full report

Failed tests

chromium › visual-comparison/docs/docs-visual-comparison.spec.ts › diff default doc content

Flaky tests

chromium › memory/memory.spec.ts › memory

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.67%. Comparing base (f23a024) to head (fdc8547).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4212      +/-   ##
==========================================
- Coverage   33.68%   33.67%   -0.02%     
==========================================
  Files        2490     2490              
  Lines      128019   128019              
  Branches    28692    28692              
==========================================
- Hits        43126    43105      -21     
- Misses      84893    84914      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gggpound Gggpound merged commit 1de083c into dev Dec 3, 2024
2 checks passed
@Gggpound Gggpound deleted the fix-cf-memory-1203 branch December 3, 2024 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants