Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: some rendering issues in doc #4219

Merged
merged 4 commits into from
Dec 10, 2024
Merged

fix: some rendering issues in doc #4219

merged 4 commits into from
Dec 10, 2024

Conversation

lumixraku
Copy link
Contributor

@lumixraku lumixraku commented Dec 3, 2024

close https://github.com/dream-num/univer-pro/issues/1548
close https://github.com/dream-num/univer-pro/issues/1121
close https://github.com/dream-num/univer-pro/issues/1167
close https://github.com/dream-num/univer-pro/issues/1181
close https://github.com/dream-num/univer-pro/issues/3628

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Dec 3, 2024
Copy link

github-actions bot commented Dec 3, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Dec 3, 2024

Playwright test results

passed  19 passed
flaky  1 flaky

Details

stats  20 tests across 9 suites
duration  5 minutes, 31 seconds
commit  99f6a80
info  For more information, see full report

Flaky tests

chromium › memory/memory.spec.ts › memory

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 5.00000% with 19 lines in your changes missing coverage. Please review.

Project coverage is 33.67%. Comparing base (f06ab86) to head (99f6a80).
Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
...engine-render/src/components/sheets/spreadsheet.ts 0.00% 7 Missing ⚠️
packages/engine-render/src/engine.ts 0.00% 5 Missing ⚠️
packages/engine-render/src/canvas.ts 0.00% 2 Missing ⚠️
...gine-render/src/components/docs/extensions/line.ts 0.00% 2 Missing ⚠️
.../src/services/editor/cell-editor-resize.service.ts 0.00% 2 Missing ⚠️
...ender/src/components/docs/extensions/background.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #4219   +/-   ##
=======================================
  Coverage   33.66%   33.67%           
=======================================
  Files        2495     2495           
  Lines      128297   128287   -10     
  Branches    28758    28756    -2     
=======================================
  Hits        43197    43197           
+ Misses      85100    85090   -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lumixraku lumixraku changed the title fix: background width issues/#1548 fix: some rendering issues in doc Dec 3, 2024
@lumixraku lumixraku self-assigned this Dec 5, 2024
@lumixraku lumixraku requested a review from Jocs as a code owner December 7, 2024 06:12
@zhaolixin7
Copy link

zhaolixin7 commented Dec 9, 2024

@lumixraku 问题1、125%时编辑态下输入内容,表现:字体模糊
问题2、编辑态切时拖拽到不同的屏幕分辨率字字体大小会变 表现:125拖到150编辑态文字会小;150%到125%字体会变大
image
image
image
问题3、分辨率125到150互相切换高亮线的位置偏移
image
image

@univer-bot
Copy link

univer-bot bot commented Dec 9, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

@lumixraku Question 1. When inputting content in editing mode at 125%, the performance: the font is blurred
Question 2. When switching between editing mode, the font size of the text will change when dragging it to different screen resolutions. Performance: dragging from 125 to 150 will make the text smaller in the editing state; when dragging from 150% to 125%, the font size will become larger.
image
image
image
Question 3. The position of the highlight line is offset when the resolution is switched from 125 to 150.
image
image

@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Dec 9, 2024
@lumixraku lumixraku force-pushed the fix/doc-bg branch 4 times, most recently from ea31d15 to 3d9debe Compare December 9, 2024 09:37
@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Dec 10, 2024
@univer-bot univer-bot bot removed the qa:rejected label Dec 10, 2024
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lumixraku lumixraku merged commit 0dd4f3d into dev Dec 10, 2024
9 checks passed
@lumixraku lumixraku deleted the fix/doc-bg branch December 10, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants