Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): url regexper #4237

Merged
merged 1 commit into from
Dec 5, 2024
Merged

fix(core): url regexper #4237

merged 1 commit into from
Dec 5, 2024

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Dec 5, 2024

remove exclusion of private & local ip address

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@weird94 weird94 requested a review from wzhudev as a code owner December 5, 2024 10:25
Copy link

github-actions bot commented Dec 5, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Dec 5, 2024

Playwright test results

passed  19 passed
flaky  1 flaky

Details

stats  20 tests across 9 suites
duration  5 minutes, 46 seconds
commit  936399e
info  For more information, see full report

Flaky tests

chromium › memory/memory.spec.ts › memory

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.69%. Comparing base (cbc58ea) to head (936399e).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #4237   +/-   ##
=======================================
  Coverage   33.69%   33.69%           
=======================================
  Files        2490     2490           
  Lines      128063   128063           
  Branches    28711    28711           
=======================================
  Hits        43145    43145           
  Misses      84918    84918           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jikkai jikkai merged commit 182f7c5 into dev Dec 5, 2024
9 checks passed
@jikkai jikkai deleted the fix/url-regexper branch December 5, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants