Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix clipboard when dispose #4253

Merged
merged 1 commit into from
Dec 10, 2024
Merged

fix: fix clipboard when dispose #4253

merged 1 commit into from
Dec 10, 2024

Conversation

ybzky
Copy link
Member

@ybzky ybzky commented Dec 7, 2024

close https://github.com/dream-num/univer-pro/issues/3428
close https://github.com/dream-num/univer-pro/issues/3429

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Dec 7, 2024
Copy link

github-actions bot commented Dec 7, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Dec 7, 2024

Playwright test results

passed  19 passed
flaky  1 flaky

Details

stats  20 tests across 9 suites
duration  5 minutes, 18 seconds
commit  427486e
info  For more information, see full report

Flaky tests

chromium › memory/memory.spec.ts › memory

Copy link

codecov bot commented Dec 7, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 33.65%. Comparing base (96efb3d) to head (427486e).
Report is 13 commits behind head on dev.

Files with missing lines Patch % Lines
...ets-ui/src/services/clipboard/clipboard.service.ts 42.85% 4 Missing ⚠️
...ts-ui/src/services/clipboard/copy-content-cache.ts 0.00% 4 Missing ⚠️
...ges/sheets-ui/src/views/permission/panel/index.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4253      +/-   ##
==========================================
- Coverage   33.65%   33.65%   -0.01%     
==========================================
  Files        2496     2495       -1     
  Lines      128140   128260     +120     
  Branches    28723    28744      +21     
==========================================
+ Hits        43129    43160      +31     
- Misses      85011    85100      +89     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Dec 9, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Dec 9, 2024
@ybzky ybzky merged commit f06ab86 into dev Dec 10, 2024
9 checks passed
@ybzky ybzky deleted the chore/fix-bugs-yb branch December 10, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants