-
-
Notifications
You must be signed in to change notification settings - Fork 714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: border stylecache in sheet skeleton #4276
Conversation
e0f1064
to
f003b34
Compare
View Deployment
|
f003b34
to
b3d5cc0
Compare
Playwright test resultsDetails 20 tests across 9 suites Flaky testschromium › memory/memory.spec.ts › memory |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #4276 +/- ##
==========================================
- Coverage 33.66% 33.64% -0.02%
==========================================
Files 2495 2497 +2
Lines 128317 128453 +136
Branches 28756 28783 +27
==========================================
+ Hits 43199 43223 +24
- Misses 85118 85230 +112 ☔ View full report in Codecov by Sentry. |
当行列选区和当前 normal 选区 border 不一致时, 如何表现? 2024_12_11.11_19_03.video.webm |
How does it behave when the border of the row and row selections is inconsistent with the current normal selection? 2024_12_11.11_19_03.video.webm |
fix: add test case for skeleton
850ffde
to
72f54e1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
packages/engine-render/src/components/sheets/__tests__/test.sheet-skeleton.spec.ts
Outdated
Show resolved
Hide resolved
72f54e1
to
10ce163
Compare
close #2509
close #3490
Pull Request Checklist