Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: border stylecache in sheet skeleton #4276

Merged
merged 4 commits into from
Dec 13, 2024
Merged

fix: border stylecache in sheet skeleton #4276

merged 4 commits into from
Dec 13, 2024

Conversation

lumixraku
Copy link
Contributor

@lumixraku lumixraku commented Dec 10, 2024

close #2509
close #3490

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Dec 10, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@lumixraku lumixraku marked this pull request as ready for review December 10, 2024 11:23
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Dec 10, 2024
Copy link

github-actions bot commented Dec 10, 2024

Playwright test results

passed  19 passed
flaky  1 flaky

Details

stats  20 tests across 9 suites
duration  5 minutes, 29 seconds
commit  10ce163
info  For more information, see full report

Flaky tests

chromium › memory/memory.spec.ts › memory

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 33.64%. Comparing base (50db7a3) to head (10ce163).
Report is 12 commits behind head on dev.

Files with missing lines Patch % Lines
...ine-render/src/components/sheets/sheet-skeleton.ts 0.00% 7 Missing ⚠️
...omponents/docs/layout/shaping-engine/font-cache.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4276      +/-   ##
==========================================
- Coverage   33.66%   33.64%   -0.02%     
==========================================
  Files        2495     2497       +2     
  Lines      128317   128453     +136     
  Branches    28756    28783      +27     
==========================================
+ Hits        43199    43223      +24     
- Misses      85118    85230     +112     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lumixraku
Copy link
Contributor Author

lumixraku commented Dec 11, 2024

当行列选区和当前 normal 选区 border 不一致时, 如何表现?

2024_12_11.11_19_03.video.webm

@univer-bot
Copy link

univer-bot bot commented Dec 11, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

How does it behave when the border of the row and row selections is inconsistent with the current normal selection?

2024_12_11.11_19_03.video.webm

@lumixraku
Copy link
Contributor Author

lumixraku commented Dec 11, 2024

prev issue
The border data does not match the drawing results.

image

@zhaolixin7 zhaolixin7 added qa:verified This PR has already by verified by a QA and is considered good enough to be merge and removed qa:untested This PR is ready to be tested labels Dec 11, 2024
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lumixraku lumixraku changed the title fix: skeleton border fix: border stylecache in sheet skeleton Dec 13, 2024
@lumixraku lumixraku merged commit af3eece into dev Dec 13, 2024
10 checks passed
@lumixraku lumixraku deleted the fix/skeleton-border branch December 13, 2024 06:16
@lumixraku lumixraku restored the fix/skeleton-border branch December 13, 2024 07:10
@jikkai jikkai deleted the fix/skeleton-border branch December 28, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
4 participants