Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add set scrolling & get scrollInfo & better freeze API for facade #4290

Merged
merged 7 commits into from
Dec 17, 2024

Conversation

lumixraku
Copy link
Contributor

@lumixraku lumixraku commented Dec 12, 2024

close #xxx

Add scrolling API for facade. And add a more comprehensible API for freezing command.

packages/sheets-ui/src/facade/f-worksheet.ts
onScroll(callback: (params: Nullable) => void):
getScrollState(): Nullable
scrollToCell(row: number, column: number): void

packages/sheets/src/facade/f-worksheet.ts
freezeRow(startRow: number, endRow: number) => void
freezeColumn(startColumn: number, endColumn: number) => void

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Dec 12, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Dec 12, 2024

Playwright test results

passed  21 passed

Details

stats  21 tests across 10 suites
duration  4 minutes, 44 seconds
commit  e15d7c7
info  For more information, see full report

@lumixraku lumixraku marked this pull request as draft December 12, 2024 12:51
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 203 lines in your changes missing coverage. Please review.

Project coverage is 33.46%. Comparing base (a1da277) to head (e15d7c7).
Report is 4 commits behind head on dev.

Files with missing lines Patch % Lines
...ers/render-controllers/scroll.render-controller.ts 0.00% 73 Missing ⚠️
packages/sheets-ui/src/facade/f-worksheet.ts 0.00% 43 Missing ⚠️
...ine-render/src/components/sheets/sheet-skeleton.ts 0.00% 37 Missing ⚠️
packages/sheets/src/facade/f-worksheet.ts 0.00% 30 Missing ⚠️
packages/sheets-ui/src/facade/f-workbook.ts 0.00% 8 Missing ⚠️
packages/engine-render/src/viewport.ts 0.00% 3 Missing ⚠️
...ets-ui/src/commands/commands/set-scroll.command.ts 0.00% 3 Missing ⚠️
packages/engine-render/src/basics/tools.ts 0.00% 2 Missing ⚠️
...ts-formula-ui/src/controllers/prompt.controller.ts 0.00% 2 Missing ⚠️
...engine-render/src/components/sheets/spreadsheet.ts 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4290      +/-   ##
==========================================
- Coverage   33.55%   33.46%   -0.09%     
==========================================
  Files        2505     2509       +4     
  Lines      129102   129494     +392     
  Branches    28896    28972      +76     
==========================================
+ Hits        43314    43332      +18     
- Misses      85788    86162     +374     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lumixraku lumixraku force-pushed the feat/facade-sk branch 2 times, most recently from 7dc7942 to e5412cf Compare December 12, 2024 13:10
@lumixraku lumixraku marked this pull request as ready for review December 12, 2024 13:10
@lumixraku lumixraku marked this pull request as draft December 12, 2024 13:21
@lumixraku lumixraku force-pushed the feat/facade-sk branch 10 times, most recently from 6fa265a to cafaebc Compare December 14, 2024 06:05
@lumixraku lumixraku marked this pull request as ready for review December 14, 2024 06:05
@lumixraku lumixraku force-pushed the feat/facade-sk branch 2 times, most recently from c7cd798 to c011814 Compare December 14, 2024 06:19
@lumixraku lumixraku changed the title feat: add set scrolling & get scrollInfo & better freeze API feat: add set scrolling & get scrollInfo & better freeze API for facade Dec 14, 2024
@lumixraku lumixraku force-pushed the feat/facade-sk branch 2 times, most recently from ac92177 to 1506367 Compare December 16, 2024 06:20
packages/sheets/src/facade/f-worksheet.ts Outdated Show resolved Hide resolved
packages/sheets/src/facade/f-worksheet.ts Show resolved Hide resolved
packages/sheets/src/facade/f-worksheet.ts Outdated Show resolved Hide resolved
packages/sheets/src/facade/f-worksheet.ts Outdated Show resolved Hide resolved
@lumixraku lumixraku force-pushed the feat/facade-sk branch 2 times, most recently from 0eea192 to 470148c Compare December 16, 2024 08:27
@lumixraku lumixraku merged commit 1bd1325 into dev Dec 17, 2024
9 checks passed
@lumixraku lumixraku deleted the feat/facade-sk branch December 17, 2024 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants