-
-
Notifications
You must be signed in to change notification settings - Fork 714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add set scrolling & get scrollInfo & better freeze API for facade #4290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lumixraku
requested review from
Jocs,
jikkai,
wzhudev and
VicKun4937
as code owners
December 12, 2024 12:42
View Deployment
|
Playwright test resultsDetails 21 tests across 10 suites |
lumixraku
force-pushed
the
feat/facade-sk
branch
2 times, most recently
from
December 12, 2024 13:10
7dc7942
to
e5412cf
Compare
lumixraku
force-pushed
the
feat/facade-sk
branch
10 times, most recently
from
December 14, 2024 06:05
6fa265a
to
cafaebc
Compare
lumixraku
requested review from
DR-Univer,
Dushusir and
hexf00
as code owners
December 14, 2024 06:05
lumixraku
force-pushed
the
feat/facade-sk
branch
2 times, most recently
from
December 14, 2024 06:19
c7cd798
to
c011814
Compare
lumixraku
changed the title
feat: add set scrolling & get scrollInfo & better freeze API
feat: add set scrolling & get scrollInfo & better freeze API for facade
Dec 14, 2024
VicKun4937
reviewed
Dec 14, 2024
VicKun4937
reviewed
Dec 14, 2024
VicKun4937
reviewed
Dec 14, 2024
VicKun4937
approved these changes
Dec 14, 2024
lumixraku
force-pushed
the
feat/facade-sk
branch
from
December 16, 2024 06:16
c011814
to
db884f7
Compare
lumixraku
force-pushed
the
feat/facade-sk
branch
2 times, most recently
from
December 16, 2024 06:20
ac92177
to
1506367
Compare
wzhudev
approved these changes
Dec 16, 2024
lumixraku
force-pushed
the
feat/facade-sk
branch
from
December 16, 2024 06:41
1506367
to
4d7eebb
Compare
Dushusir
approved these changes
Dec 16, 2024
hexf00
requested changes
Dec 16, 2024
jikkai
approved these changes
Dec 16, 2024
hexf00
approved these changes
Dec 16, 2024
lumixraku
force-pushed
the
feat/facade-sk
branch
2 times, most recently
from
December 16, 2024 08:27
0eea192
to
470148c
Compare
lumixraku
force-pushed
the
feat/facade-sk
branch
from
December 17, 2024 02:44
470148c
to
e15d7c7
Compare
Jocs
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #xxx
Add scrolling API for facade. And add a more comprehensible API for freezing command.
packages/sheets-ui/src/facade/f-worksheet.ts
onScroll(callback: (params: Nullable) => void):
getScrollState(): Nullable
scrollToCell(row: number, column: number): void
packages/sheets/src/facade/f-worksheet.ts
freezeRow(startRow: number, endRow: number) => void
freezeColumn(startColumn: number, endColumn: number) => void
Pull Request Checklist