Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): add more facade #4291

Merged
merged 6 commits into from
Dec 13, 2024
Merged

feat(ui): add more facade #4291

merged 6 commits into from
Dec 13, 2024

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Dec 13, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@wzhudev wzhudev requested review from jikkai and Jocs as code owners December 13, 2024 03:19
@wzhudev wzhudev marked this pull request as draft December 13, 2024 03:19
Copy link

github-actions bot commented Dec 13, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@wzhudev wzhudev marked this pull request as ready for review December 13, 2024 03:24
Copy link

github-actions bot commented Dec 13, 2024

Playwright test results

passed  20 passed

Details

stats  20 tests across 9 suites
duration  4 minutes, 47 seconds
commit  eac0ae3
info  For more information, see full report

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 33.64%. Comparing base (8619410) to head (eac0ae3).
Report is 4 commits behind head on dev.

Files with missing lines Patch % Lines
packages/sheets/src/facade/f-univer.ts 0.00% 5 Missing ⚠️
packages/ui/src/facade/f-univer.ts 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4291      +/-   ##
==========================================
- Coverage   33.64%   33.64%   -0.01%     
==========================================
  Files        2497     2497              
  Lines      128453   128461       +8     
  Branches    28783    28780       -3     
==========================================
  Hits        43223    43223              
- Misses      85230    85238       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wzhudev wzhudev requested a review from VicKun4937 as a code owner December 13, 2024 05:16
@wzhudev wzhudev merged commit 3254073 into dev Dec 13, 2024
9 checks passed
@wzhudev wzhudev deleted the feat/ui-facade branch December 13, 2024 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants